piotr-szuberski commented on a change in pull request #12827:
URL: https://github.com/apache/beam/pull/12827#discussion_r495886039
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTableProviderIT.java
##########
@@ -67,19 +67,25 @@
import org.testcontainers.containers.KafkaContainer;
/** This is an integration test for KafkaCSVTable. */
-public class KafkaCSVTableIT {
+public abstract class KafkaTableProviderIT {
@Rule public transient TestPipeline pipeline = TestPipeline.create();
@Rule public transient KafkaContainer kafka = new KafkaContainer();
- private KafkaOptions kafkaOptions;
+ protected KafkaOptions kafkaOptions;
- private static final Schema TEST_TABLE_SCHEMA =
+ protected static final Schema TEST_TABLE_SCHEMA =
Schema.builder()
.addNullableField("order_id", Schema.FieldType.INT32)
.addNullableField("member_id", Schema.FieldType.INT32)
.addNullableField("item_name", Schema.FieldType.INT32)
Review comment:
CSV is quite problematic here as most fields (bool, Row, etc) are
indistinguishable by the default csv parser. I'll make a getSchema() abstract
and provide different fields for Avro and Csv.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
