ahmedabu98 commented on code in PR #38490:
URL: https://github.com/apache/beam/pull/38490#discussion_r3276074685
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvoker.java:
##########
@@ -442,6 +453,7 @@ public <T> void output(TupleTag<T> tag, T value) {
@Override
public <T> void outputWithTimestamp(TupleTag<T> tag, T value, Instant
timestamp) {
+ noteOutput();
Review Comment:
I noticed it was missing and thought it could be a bug (other output methods
will call `noteOutput();` but not this one). I'll remove it for now though cuz
it's not in this PR's scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]