stankiewicz commented on code in PR #38490:
URL: https://github.com/apache/beam/pull/38490#discussion_r3276100786
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1813,14 +1831,35 @@ public <T> void outputWindowedValue(
Instant timestamp,
Collection<? extends BoundedWindow> windows,
PaneInfo paneInfo) {
+ outputWindowedValue(tag, output, timestamp, windows, paneInfo,
ValueKind.INSERT);
+ }
+
+ public <T> void outputWindowedValue(
Review Comment:
remove
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -2659,6 +2733,16 @@ public void outputWindowedValue(
OutputReceiver.super.outputWindowedValue(output, timestamp, windows,
paneInfo);
}
+ @Override
+ public void outputWindowedValue(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
