iht commented on code in PR #38603:
URL: https://github.com/apache/beam/pull/38603#discussion_r3290469065
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/read/UnboundedSolaceReader.java:
##########
@@ -151,30 +155,35 @@ public boolean advance() {
}
solaceOriginalRecord = receivedXmlMessage;
solaceMappedRecord =
getCurrentSource().getParseFn().apply(receivedXmlMessage);
- receivedMessages.add(receivedXmlMessage);
+ synchronized (this) {
+ receivedMessages.add(receivedXmlMessage);
+ }
return true;
}
@Override
public void close() {
- finalizeReadyMessages();
sessionServiceCache.invalidate(readerUuid);
+ ActiveReadersRegistry.unregister(readerUuid);
}
- public void finalizeReadyMessages() {
- BytesXMLMessage msg;
- while ((msg = safeToAckMessages.poll()) != null) {
+ public void finalizeCheckpoint(long checkpointId) {
Review Comment:
Done in second commit submitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
