jrmccluskey commented on code in PR #37639:
URL: https://github.com/apache/beam/pull/37639#discussion_r3325435645
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -1252,95 +1265,3 @@ def
_verify_interpreter_version_is_supported(pipeline_options):
'using an unsupported version of Python interpreter, pass '
'--experiment use_unsupported_python_version pipeline option.' %
(_PYTHON_VERSIONS_SUPPORTED_BY_DATAFLOW, sys.version))
-
-
-# To enable a counter on the service, add it to this dictionary.
-# This is required for the legacy python dataflow runner, as portability
-# does not communicate to the service via python code, but instead via a
-# a runner harness (in C++ or Java).
-# TODO(https://github.com/apache/beam/issues/19433) : Remove this antipattern,
-# legacy dataflow python pipelines will break whenever a new cy_combiner type
-# is used.
-structured_counter_translations = {
Review Comment:
As best I can tell, this code _was_ necessary for pre-portability pipelines
but has been unused for some time. I cannot find a reference to these maps
either internally or externally, removing them doesn't seem to make a
difference in tests in either environment, and dataflow itself doesn't allow
non-runner v2 jobs from 2.45.0 on anyway. There's a corresponding
cy_combiner.py / .pyx file set in transforms that I can likely clean up later,
as that code doesn't appear to be used anywhere else either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
