jrmccluskey commented on code in PR #37639:
URL: https://github.com/apache/beam/pull/37639#discussion_r3325454723
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -466,18 +464,15 @@ def __init__(self, options, proto_pipeline):
if '{' in label:
label = ast.literal_eval(label)
for key, value in label.items():
- self.proto.labels.additionalProperties.append(
- dataflow.Job.LabelsValue.AdditionalProperty(
- key=key, value=value))
+ self.proto.labels.update({key: value})
Review Comment:
There is not an additional_properties field in the dataflow Job proto in the
GAPIC client -
https://docs.cloud.google.com/python/docs/reference/dataflow/latest/google.cloud.dataflow_v1beta3.types.Job
Confusingly, there's a LabelsEntry class that seemingly exists to hold this
information that goes entirely unused in the spec for Job protos in favor of
the labels MutableMapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
