Abacn commented on code in PR #38493:
URL: https://github.com/apache/beam/pull/38493#discussion_r3393116051
##########
sdks/java/io/expansion-service/build.gradle:
##########
@@ -89,6 +89,8 @@ dependencies {
permitUnusedDeclared project(":sdks:java:io:kafka:upgrade") // BEAM-11761
implementation project(":sdks:java:extensions:kafka-factories")
permitUnusedDeclared project(":sdks:java:extensions:kafka-factories")
+ implementation project(":sdks:java:io:mqtt")
Review Comment:
Also with @chamikaramj we recommend put mqttio into a new expansion service
module,
I'm considering either in io/mqtt/expansion-service or a bit generic
io/messagin-expansion-service that serving messaging protocols (mqtt, and
possibly jms, solace in the future)
##########
sdks/java/io/expansion-service/build.gradle:
##########
@@ -89,6 +89,8 @@ dependencies {
permitUnusedDeclared project(":sdks:java:io:kafka:upgrade") // BEAM-11761
implementation project(":sdks:java:extensions:kafka-factories")
permitUnusedDeclared project(":sdks:java:extensions:kafka-factories")
+ implementation project(":sdks:java:io:mqtt")
Review Comment:
Also discussed with @chamikaramj we recommend put mqttio into a new
expansion service module,
I'm considering either in io/mqtt/expansion-service or a bit generic
io/messagin-expansion-service that serving messaging protocols (mqtt, and
possibly jms, solace in the future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
