tkaymak commented on code in PR #38493:
URL: https://github.com/apache/beam/pull/38493#discussion_r3393951859
##########
sdks/java/io/expansion-service/build.gradle:
##########
@@ -89,6 +89,8 @@ dependencies {
permitUnusedDeclared project(":sdks:java:io:kafka:upgrade") // BEAM-11761
implementation project(":sdks:java:extensions:kafka-factories")
permitUnusedDeclared project(":sdks:java:extensions:kafka-factories")
+ implementation project(":sdks:java:io:mqtt")
Review Comment:
Good call — done in `2204a9d79d0`. I went with the broader option: a new
`:sdks:java:io:messaging-expansion-service` module (rather than mqtt-specific),
so JMS/Solace can be added to it later without another module or a rename.
- MqttIO is no longer added to `:sdks:java:io:expansion-service` (that
change is reverted).
- The new module pulls in only `:sdks:java:expansion-service` +
`:sdks:java:io:mqtt` (shadowJar is ~60 MB vs the io service's ~466 MB).
- `standard_expansion_services.yaml` now has a second entry for the
messaging service emitting `ReadFromMqtt`/`WriteToMqtt`; it skips the core
SchemaTransforms it bundles transitively (`generate_sequence`, `tfrecord_*`),
which keep being generated from the io service. Regenerated
`standard_external_transforms.yaml` accordingly, and registered the new target
in `generateExternalTransformsConfig` and the xlang `servicesToGenerateFrom`
list.
Verified the new service end-to-end over xlang (Python → `ReadFromMqtt`,
batch + streaming on Prism) against a local broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
