Abacn commented on code in PR #38974:
URL: https://github.com/apache/beam/pull/38974#discussion_r3437910276
##########
.github/actions/setup-environment-action/action.yml:
##########
@@ -69,9 +69,15 @@ runs:
tox-${{ runner.os }}-py${{ inputs.python-version == 'default' &&
'310' || inputs.python-version }}-${{ hashFiles('sdks/python/tox.ini') }}-
tox-${{ runner.os }}-py${{ inputs.python-version == 'default' &&
'310' || inputs.python-version }}-
+ - name: Install Java 17 fallback
+ if: ${{ inputs.java-version == 'default' }}
+ uses: actions/setup-java@v4
+ with:
+ distribution: 'temurin'
Review Comment:
Now java-version set to default means to install both Java11 and 17. This
may work for fixing some test but makes future maintenance harder (more complex
and implicit java version logic)
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -507,6 +507,17 @@ class BeamModulePlugin implements Plugin<Project> {
project.ext.mavenGroupId = 'org.apache.beam'
+ ['11', '17', '21', '25'].each { version ->
+ def propName = "java${version}Home"
+ if (!project.hasProperty(propName)) {
+ def home = System.getenv("JAVA_HOME_${version}_X64") ?:
+ (System.getenv("JAVA_HOME_${version}_ARM64") ?:
System.getenv("JAVA_HOME_${version}_arm64"))
Review Comment:
Beam module plugin should be independent of GitHub Action specific
arangement. Better avoiding further complicated fallback mechanism and/or
making our build system tied to GitHub Action infra
Doesn't setting java17Home property in individual tests work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
