Abacn commented on code in PR #38974:
URL: https://github.com/apache/beam/pull/38974#discussion_r3437910276
##########
.github/actions/setup-environment-action/action.yml:
##########
@@ -69,9 +69,15 @@ runs:
tox-${{ runner.os }}-py${{ inputs.python-version == 'default' &&
'310' || inputs.python-version }}-${{ hashFiles('sdks/python/tox.ini') }}-
tox-${{ runner.os }}-py${{ inputs.python-version == 'default' &&
'310' || inputs.python-version }}-
+ - name: Install Java 17 fallback
+ if: ${{ inputs.java-version == 'default' }}
+ uses: actions/setup-java@v4
+ with:
+ distribution: 'temurin'
Review Comment:
Now java-version set to default means to install both Java11 and 17. This
may work for fixing some test but makes future maintenance harder (more complex
and implicit java version logic) and also making future breaking changes that
effectively invalidate Java11 support (combine with the env fallback below)
slips in
I would prefer make Java17 requirement explicit that is explicitly change
java-version to "17 11" for the affected GHA workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
