gemini-code-assist[bot] commented on code in PR #39017: URL: https://github.com/apache/beam/pull/39017#discussion_r3438114020
########## sdks/python/apache_beam/testing/benchmarks/cloudml/requirements.txt: ########## @@ -15,12 +15,13 @@ # limitations under the License. # -dill==0.4.1 -tfx_bsl==1.16.1 -tensorflow-transform==1.16.0 -tensorflow>=2.16,<2.17 +# Core TFT dependencies with version bounds Review Comment:  To prevent developers or automated scripts from hitting `ResolutionTooDeep` errors when installing these requirements directly, it is highly recommended to document that the constraints file should be used. ``` # Core TFT dependencies with version bounds.\n# Note: To avoid pip ResolutionTooDeep errors, always install using the constraints file:\n# pip install -c constraints.txt -r requirements.txt ``` ########## sdks/python/apache_beam/testing/benchmarks/cloudml/constraints.txt: ########## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Constraints file to pin versions and avoid pip ResolutionTooDeep. +# This file is used with: pip install -c constraints.txt -r requirements.txt + +# Core dependencies +tfx_bsl==1.15.1 +tensorflow-transform==1.15.0 + +# TensorFlow ecosystem +tensorflow==2.15.1 +tensorflow-metadata==1.15.0 +tf-keras==2.15.1 Review Comment:  For completeness and to ensure consistent resolution of all TensorFlow ecosystem packages, consider pinning `tensorflow-serving-api` in the constraints file as well, since it is specified in `requirements.txt`. ``` # TensorFlow ecosystem\ntensorflow==2.15.1\ntensorflow-metadata==1.15.0\ntf-keras==2.15.1\ntensorflow-serving-api==2.15.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
