Abacn commented on code in PR #39465:
URL: https://github.com/apache/beam/pull/39465#discussion_r3675652288
##########
sdks/python/apache_beam/transforms/periodicsequence.py:
##########
@@ -166,9 +166,26 @@ def process(
current_output_timestamp = start + interval * current_output_index
if current_output_timestamp > time.time():
- # we are too ahead of time, let's wait.
- restriction_tracker.defer_remainder(
- timestamp.Timestamp(current_output_timestamp))
+ # We are ahead of time, let's wait. No element will be produced before
Review Comment:
Let's simplify the comments to be just informative. Just say
> we are too ahead of time, let's wait.
> Advance the watermark up to the next element's timestamp
> as no element is expected before that time.
The discussion of this PR and its Issue is sufficient for reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
