Abacn commented on code in PR #39465:
URL: https://github.com/apache/beam/pull/39465#discussion_r3675710316
##########
sdks/python/apache_beam/transforms/periodicsequence_test.py:
##########
@@ -368,5 +373,61 @@ def test_rebase_timestamp_with_wrong_setting(self):
rebase=RebaseMode.REBASE_START))
+class ImpulseSeqGenDoFnWatermarkTest(unittest.TestCase):
Review Comment:
~The newly added tests still passing on HEAD, indicates it's not guarding
the regression reported here~
Sorry, `test_watermark_advances_to_next_fire_on_defer` does failing.
`test_watermark_not_advanced_past_emitted_for_pre_timestamped` passed (expected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
