je-ik commented on code in PR #39578:
URL: https://github.com/apache/beam/pull/39578#discussion_r3702033466
##########
runners/kafka-streams/src/main/java/org/apache/beam/runners/kafka/streams/translation/ExecutableStageProcessor.java:
##########
@@ -253,6 +285,18 @@ private FnDataReceiver<WindowedValue<?>>
mainInputReceiver() {
}
private void closeBundleAndFlush(Record<byte[], KStreamsPayload<?>> record) {
+ byte[] key = record.key();
+ closeBundleAndFlush(key == null ? lastKey : key, record.timestamp());
Review Comment:
Does it mean that closing the bundle by time will come in a different PR?
And out of curiosity - the stateless (and therefore keyless) ExecutableStage
_should_ have null key in KafkaRecord and this null key should be passed
downstream, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
