Abacn commented on code in PR #39939:
URL: https://github.com/apache/beam/pull/39939#discussion_r3897661750
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/SparkSessionFactory.java:
##########
@@ -288,11 +289,63 @@ public void registerClasses(Kryo kryo) {
kryo.register(CoGbkResultSchema.class);
kryo.register(TupleTag.class);
kryo.register(TupleTagList.class);
+
+ // Spark internals only present when running streaming pipelines on
Spark 4. These are
+ // registered by name because the shared runner base also compiles
against Spark 3, where
Review Comment:
> because the shared runner base also compiles against Spark 3
this isn't accurate. The sources are compiled on either Spark 3 or 4,
producing different Beam artifact.
In any case, please simplify the comment strings. It's unnecessarily verbose
as AI tends to write down all its try path into comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
