tkaymak commented on code in PR #39939:
URL: https://github.com/apache/beam/pull/39939#discussion_r3902654441
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/SparkSessionFactory.java:
##########
@@ -288,11 +289,63 @@ public void registerClasses(Kryo kryo) {
kryo.register(CoGbkResultSchema.class);
kryo.register(TupleTag.class);
kryo.register(TupleTagList.class);
+
+ // Spark internals only present when running streaming pipelines on
Spark 4. These are
+ // registered by name because the shared runner base also compiles
against Spark 3, where
Review Comment:
Yes, that makes sense. I will clean this up and follow up from #39906 in a
separate small PR. Thank you!
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/SparkSessionFactory.java:
##########
@@ -288,11 +289,63 @@ public void registerClasses(Kryo kryo) {
kryo.register(CoGbkResultSchema.class);
kryo.register(TupleTag.class);
kryo.register(TupleTagList.class);
+
+ // Spark internals only present when running streaming pipelines on
Spark 4. These are
+ // registered by name because the shared runner base also compiles
against Spark 3, where
Review Comment:
Done in 4815a681e77, comments trimmed and the wording now says the shared
sources are compiled once per Spark version into separate artifacts. The follow
up from #39906 is addressed in a separate small PR, linked there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
