shunping opened a new pull request, #40568:
URL: https://github.com/apache/beam/pull/40568

   ## Problem
   `GoogleCloudOptions.dataflow_endpoint` defaulted to 
`https://dataflow.googleapis.com`, and `DataflowApplicationClient` always 
passed it to the Dataflow GAPIC clients as `ClientOptions(api_endpoint=...)`. 
In the GCP client libraries, an explicit `api_endpoint` takes precedence over 
`GOOGLE_CLOUD_UNIVERSE_DOMAIN`, so the default Google universe (GDU) URL was 
always used. This breaks job submission in non-GDU universes such as TPC.
   
   ### Changes
   - **`--dataflow_endpoint` defaults to `''`** (same as the Go SDK). When 
unset, no `api_endpoint` override is passed, so the client library resolves the 
endpoint (honoring `GOOGLE_CLOUD_UNIVERSE_DOMAIN`, otherwise 
`dataflow.googleapis.com`). An explicit value still overrides as before.
   - **Validator:** `dataflow_endpoint` is now optional; the URL is only 
validated when provided.
   - **Remove legacy `taskrunner_settings`** from the worker pool. They only 
applied to the legacy (Runner v1) worker, which Python no longer supports, and 
hard-coded the GDU URL as `base_url`. The Go and Java SDKs never set them, and 
the Dataflow service doesn't echo them back.
   
   ### Compatibility
   Code that reads `options.view_as(GoogleCloudOptions).dataflow_endpoint` and 
expects the GDU URL
   will now get `''` when the flag isn't set.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to