tvalentyn commented on code in PR #40568:
URL: https://github.com/apache/beam/pull/40568#discussion_r4276220224
##########
sdks/python/apache_beam/options/pipeline_options_validator.py:
##########
@@ -168,9 +168,9 @@ def is_service_runner(self):
dataflow_endpoint = (
self.options.view_as(GoogleCloudOptions).dataflow_endpoint)
- if dataflow_endpoint is None:
- return False
- else:
+ # An unset endpoint means the default Dataflow service endpoint (resolved
Review Comment:
nit: we don't have to repeat these comment, seems like a distraction here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
