shunping commented on PR #40565: URL: https://github.com/apache/beam/pull/40565#issuecomment-6170253092
Hi @raams95, thank you for reporting this issue and submitting a fix. After looking closer at the problem, I want to point out that the `rebase` parameter actually achieves the exact same thing you are trying to do here—it rebases the start timestamp to the pipeline's actual execution time rather than the import time. I'm going to close this PR to avoid redundant logic, but please let me know if there is a specific edge case you found that `rebase` doesn't cover? References: - https://github.com/apache/beam/blob/0c95a398eb9d466de2e26b1d54b764d1086225cd/sdks/python/apache_beam/transforms/periodicsequence.py#L300 - https://github.com/apache/beam/blob/0c95a398eb9d466de2e26b1d54b764d1086225cd/sdks/python/apache_beam/transforms/periodicsequence.py#L230-L239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
