jbonofre opened a new pull request, #40605:
URL: https://github.com/apache/beam/pull/40605

   `JmsCheckpointMark` keeps its messages, consumer and session in `transient` 
fields. A mark that is serialized and restored, or finalized after the reader 
was recreated, therefore acknowledges nothing and the messages are redelivered.
   
   This gives each mark an id and keeps live marks in a per-JVM registry, so a 
restored copy finalizes the live checkpoint with the same id. The entry is 
removed on finalize, and entries not finalized within an hour are dropped (the 
broker redelivers them).
   
   Motivated by a Dataflow streaming job (CLIENT_ACKNOWLEDGE, 
`withRequiresDeduping()`) where dequeues stayed near zero while readers were 
recreated every few seconds. This is a hypothesis for that behavior, not yet 
confirmed. It does not help if finalize is delivered to a different JVM, or if 
the old connection is already closed.
   
   Adds a test that serializes and restores a mark and checks the original 
message is acked.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to