prodriguezdefino commented on PR #40508: URL: https://github.com/apache/beam/pull/40508#issuecomment-6403829238
[These](https://github.com/apache/beam/pull/40508#pullrequestreview-5642032882) findings don't match this revision (f9338b3), so they look like they came from a different version of the code or where hallucinated: - `local-env-setup.sh` has no `command -v rustup && … || curl` chain. It checks `type -P rustc` in an if block. - There is no `sdks/rust/build.gradle.kts` and no `cargoTest`. `test` is itself an `Exec task` that runs `cargo test` (gradle/cargo.gradle). - `sdks/rust/Cargo.lock` is tracked. It is only excluded from RAT, not `gitignored`. - `beam/model/build.rs` already emits rerun-if-changed for each .proto file. - repository is already https://github.com/apache/beam. /gemini review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
