prodriguezdefino commented on code in PR #40508: URL: https://github.com/apache/beam/pull/40508#discussion_r4385006630
########## release/src/main/scripts/set_version.sh: ########## @@ -115,4 +118,5 @@ if [[ "$GIT_ADD" == yes ]] ; then git add runners/google-cloud-dataflow-java/build.gradle git add sdks/typescript/package.json git add scripts/beam-sql.sh + git add 'sdks/rust/*Cargo.toml' sdks/rust/Cargo.lock Review Comment: Single-quoting `'sdks/rust/*Cargo.toml'` prevents shell expansion and passes the `pathspec` directly to Git. In standard Git `pathspecs` (without `:(glob))`, `*` matches across `/` (`FNM_PATHNAME` is not set), so `'sdks/rust/*Cargo.toml'` matches both the root `sdks/rust/Cargo.toml` and any nested `sdks/rust/**/Cargo.toml` at arbitrary depth in a single pattern. Verified with git ls-files -- `'sdks/rust/*Cargo.toml'`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
