suztomo commented on a change in pull request #11156:
URL: https://github.com/apache/beam/pull/11156#discussion_r502063556



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1210,6 +1222,18 @@ class BeamModulePlugin implements Plugin<Project> {
                         configuration: (configuration.shadowClosure ? 'shadow' 
: 'compile'), scope: 'compile')
                 generateDependenciesFromConfiguration(configuration: 
'provided', scope: 'provided')
 
+                if (!boms.isEmpty()) {

Review comment:
       When this Beam module uses a BOM, we need to set dependencyManagent 
element




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to