shunping commented on code in PR #41021:
URL: https://github.com/apache/beam/pull/41021#discussion_r4514154043
##########
sdks/go/pkg/beam/core/metrics/metrics.go:
##########
@@ -96,6 +96,25 @@ func (ctx *beamCtx) Value(key any) any {
} else {
// It's not created previously
ctx.store.mu.Lock()
+ // Reuse the counterset already registered in
this store
Review Comment:
Could you make the comment here (and all the newly added comments in the PR)
more concise? I am afraid it is a bit too verbose.
##########
sdks/go/pkg/beam/core/runtime/exec/combine.go:
##########
@@ -74,7 +74,13 @@ func (n *Combine) Up(ctx context.Context) error {
n.states = metrics.NewPTransformState(n.PID)
- if _, err := InvokeWithoutEventTime(ctx, n.Fn.SetupFn(), nil, nil, nil,
nil, nil); err != nil {
+ // Tag the Setup context with this transform's ID, as ParDo does, so
Review Comment:
Same about the the verbosity of the comment.
The sentence of "Without it..." can be deleted I think. We can keep the
apache issue for reference though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
