pabloem commented on a change in pull request #13055:
URL: https://github.com/apache/beam/pull/13055#discussion_r502683616
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/RowWriterFactory.java
##########
@@ -40,23 +40,35 @@ private RowWriterFactory() {}
String tempFilePrefix, DestinationT destination) throws Exception;
static <ElementT, DestinationT> RowWriterFactory<ElementT, DestinationT>
tableRows(
- SerializableFunction<ElementT, TableRow> toRow) {
- return new TableRowWriterFactory<ElementT, DestinationT>(toRow);
+ SerializableFunction<ElementT, TableRow> toRow,
+ SerializableFunction<ElementT, TableRow> toFailsafeRow) {
+ return new TableRowWriterFactory<ElementT, DestinationT>(toRow,
toFailsafeRow);
}
static final class TableRowWriterFactory<ElementT, DestinationT>
extends RowWriterFactory<ElementT, DestinationT> {
private final SerializableFunction<ElementT, TableRow> toRow;
+ private final SerializableFunction<ElementT, TableRow> toFailsafeRow;
- private TableRowWriterFactory(SerializableFunction<ElementT, TableRow>
toRow) {
+ private TableRowWriterFactory(
+ SerializableFunction<ElementT, TableRow> toRow,
+ SerializableFunction<ElementT, TableRow> toFailsafeRow) {
this.toRow = toRow;
+ this.toFailsafeRow = toFailsafeRow; // TODO yummy
Review comment:
yum yum? : ) remove?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
