paragpratim commented on code in PR #41329:
URL: https://github.com/apache/beam/pull/41329#discussion_r4572504198
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java:
##########
@@ -529,7 +532,14 @@ private PendingJob startLoad(
jobRef,
jobId.getRetryIndex());
try {
- jobService.startLoadJob(jobRef, loadConfig);
+ if (loadJobReservation == null) {
+ jobService.startLoadJob(jobRef, loadConfig);
+ } else {
+ String reservation = loadJobReservation.get();
+ checkArgument(
Review Comment:
Thanks for catching this. I updated both the regular-load and schema-update
paths so a runtime reservation provider that resolves to null is treated as
unset, matching withLoadJobProjectId; the load job is then submitted without an
explicit reservation. Empty strings remain invalid, consistent with the String
overload’s validation. I added tests for the unset runtime-provider case in
both paths, and the targeted tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
