paragpratim commented on code in PR #41329:
URL: https://github.com/apache/beam/pull/41329#discussion_r4572513318
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -308,6 +308,57 @@ public void startLoadJob(
startJobStream(job, stream, errorExtractor, client, Sleeper.DEFAULT,
createDefaultBackoff());
}
+ /**
+ * {@inheritDoc}
+ *
+ * <p>Tries executing the RPC for at most {@code MAX_RPC_RETRIES} times
until it succeeds.
+ *
+ * @throws IOException if it exceeds {@code MAX_RPC_RETRIES} attempts.
+ */
+ @Override
+ public void startLoadJob(
Review Comment:
Thanks for the suggestion. Both existing overloads now delegate to their
reservation-aware counterparts with null, removing the duplicate job
construction. I also added coverage for stream-load requests with and without a
reservation. The targeted tests and style checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
