piotr-szuberski commented on a change in pull request #12827:
URL: https://github.com/apache/beam/pull/12827#discussion_r503903580
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/BeamKafkaTable.java
##########
@@ -91,12 +91,14 @@ public BeamKafkaTable updateConsumerProperties(Map<String,
Object> configUpdates
return PCollection.IsBounded.UNBOUNDED;
}
- public abstract PTransform<PCollection<KV<byte[], byte[]>>, PCollection<Row>>
+ protected abstract PTransform<PCollection<KV<byte[], byte[]>>,
PCollection<Row>>
getPTransformForInput();
- public abstract PTransform<PCollection<Row>, PCollection<KV<byte[], byte[]>>>
+ protected abstract PTransform<PCollection<Row>, PCollection<KV<byte[],
byte[]>>>
getPTransformForOutput();
+ protected abstract BeamKafkaTable getTable();
+
Review comment:
You're right. Thanks for your keen eye!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
