TheNeuralBit commented on a change in pull request #13126:
URL: https://github.com/apache/beam/pull/13126#discussion_r508925941
##########
File path: sdks/python/apache_beam/dataframe/schemas.py
##########
@@ -146,15 +146,21 @@ class BatchRowsAsDataFrame(beam.PTransform):
Batching parameters are inherited from
:class:`~apache_beam.transforms.util.BatchElements`.
"""
- def __init__(self, *args, **kwargs):
+ def __init__(self, *args, proxy, **kwargs):
Review comment:
Yeah definitely preferable to generate once... what if we make this
`proxy=None` for now, with default behavior to generate the proxy. In the
future we could consider propagating that proxy to DataframeTransform through a
typehint to remove the need for generating it in `to_pcollection`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
