robertwb commented on a change in pull request #13126:
URL: https://github.com/apache/beam/pull/13126#discussion_r507917596
##########
File path: sdks/python/apache_beam/dataframe/schemas.py
##########
@@ -146,15 +146,21 @@ class BatchRowsAsDataFrame(beam.PTransform):
Batching parameters are inherited from
:class:`~apache_beam.transforms.util.BatchElements`.
"""
- def __init__(self, *args, **kwargs):
+ def __init__(self, *args, proxy, **kwargs):
Review comment:
I think it's preferable to compute it in one place and pass the desired
shape around elsewhere. In addition, this opens the possibility that the user
may want to manually specify a shape that cannot be inferred (or would be
inferred differently, e.g. the user wants a Series of floats and passes a
PCollection of float-convertable things). Granted we don't yet expose that to
the public API, but it would make sense in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
