tysonjh commented on a change in pull request #13282:
URL: https://github.com/apache/beam/pull/13282#discussion_r521603774
##########
File path: .test-infra/jenkins/job_PerformanceTests_KafkaIO_IT.groovy
##########
@@ -61,14 +61,60 @@ job(jobName) {
autoscalingAlgorithm : 'NONE'
]
+ Map runnerV2SdfWrapperPipelineOptions = pipelineOptions + [
Review comment:
Maybe including the word 'Dataflow' would be informative for these
configs.
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -233,6 +233,8 @@ class BeamModulePlugin implements Plugin<Project> {
// Required. Pipeline options to be used by the tested pipeline.
String integrationTestPipelineOptions =
System.getProperty('integrationTestPipelineOptions')
+
+ String experiment = System.getProperty('experiment', '')
Review comment:
Adding an 'experiment' flag here could be confused with the
pipelineOptions experiment flag. Maybe instead of this, it would be better to
inspect the pipelineOptions instead?
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1442,7 +1447,7 @@ class BeamModulePlugin implements Plugin<Project> {
JavaPerformanceTestConfiguration configuration = it ? it as
JavaPerformanceTestConfiguration : new JavaPerformanceTestConfiguration()
// Task for running integration tests
- project.task('integrationTest', type: Test) {
+ def itTask = project.task('integrationTest', type: Test) {
Review comment:
I'm not very familiar with this file, but it seems like we're now
configuring runnerv2 tasks (e.g. cleanup tasks, building container images)
based on various settings (e.g. pipelineOptions, the gradle 'experiment' flag)
here and also in various build.gradle files.
Should we be picking one over the other? For example, the PR you're
reviewing of mine that contains IT tests for examples, configures the tests in
the build.gradle file. It seems strikingly similar to what is going on here
though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
