boyuanzz commented on a change in pull request #13282:
URL: https://github.com/apache/beam/pull/13282#discussion_r521635255
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1442,7 +1447,7 @@ class BeamModulePlugin implements Plugin<Project> {
JavaPerformanceTestConfiguration configuration = it ? it as
JavaPerformanceTestConfiguration : new JavaPerformanceTestConfiguration()
// Task for running integration tests
- project.task('integrationTest', type: Test) {
+ def itTask = project.task('integrationTest', type: Test) {
Review comment:
This file defines several common project configurations, which can be
applied to any subproject.
Comparing to the solution we have for dataflow build, one benefit of using
such configuration to create IT is that we can have one centralized place for
all IO to set up ITs instead of having them one by one and it's easier to use
one test configuration to invoke tests on different runners. Taking this
KafkaIO IT as an example, if one day Flink is interested in this suite, Flink
can just use the same configuration in
https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_PerformanceTests_KafkaIO_IT.groovy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
