emilymye commented on a change in pull request #13211:
URL: https://github.com/apache/beam/pull/13211#discussion_r521889825
##########
File path: sdks/java/container/build.gradle
##########
@@ -86,51 +76,21 @@ licenseReport {
renderers = [new JsonReportRenderer()]
}
-def imageJavaVersion = project.hasProperty('imageJavaVersion') ?
project.findProperty('imageJavaVersion') : '8'
-docker {
- name containerImageName(
- name:
"${project.docker_image_default_repo_prefix}java${imageJavaVersion}_sdk",
- root: project.rootProject.hasProperty(["docker-repository-root"]) ?
- project.rootProject["docker-repository-root"] :
- project.docker_image_default_repo_root,
- tag: project.rootProject.hasProperty(["docker-tag"]) ?
- project.rootProject["docker-tag"] : project.sdk_version)
- dockerfile project.file("./Dockerfile")
- files "./build/"
- buildArgs([
- 'pull_licenses': project.rootProject.hasProperty(["docker-pull-licenses"])
||
- project.rootProject.hasProperty(["isRelease"]),
- 'java_version': imageJavaVersion,
- ])
+task buildAll {
Review comment:
split a PR but didn't move this over to the followup - will do so!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
