kennknowles commented on pull request #13306: URL: https://github.com/apache/beam/pull/13306#issuecomment-726224273
Just checking: the interface for a SQL aggregation function is "can give you a CombineFn"? I understand this is the current status of UDAFs. Is that where we want to leave it? I think the main value of a separate interface (style nit: prefer to separate the interface from this particular implementation) would be a slight decoupling. (non-blocking, just questions & comments & I'll leave it to others) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
