je-ik commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524333570
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTranslationContext.java
##########
@@ -84,6 +85,17 @@ public void setOutputDataStream(PValue value, DataStream<?>
set) {
}
}
+ <T extends PValue> void setProducer(T value, PTransform<?, T> producer) {
+ if (!producers.containsKey(value)) {
Review comment:
Should this be turned to `Precondition.checkState`?
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/WorkItemKeySelector.java
##########
@@ -49,6 +52,6 @@ public ByteBuffer
getKey(WindowedValue<SingletonKeyedWorkItem<K, V>> value) thro
@Override
public TypeInformation<ByteBuffer> getProducedType() {
- return new GenericTypeInfo<>(ByteBuffer.class);
+ return new CoderTypeInformation<>(FlinkKeyUtils.ByteBufferCoder.of(),
pipelineOptions.get());
Review comment:
This looks unrelated, can you just explain this modification? I suppose
it is correct, just wonder why it was `GenericTypeInfo` before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
