mxm commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524634584
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java
##########
@@ -971,7 +987,9 @@ public void translateNode(
.transform(fullName, outputTypeInfo, (OneInputStreamOperator)
doFnOperator)
.uid(fullName);
- context.setOutputDataStream(context.getOutput(transform), outDataStream);
+ final PCollection<KV<K, Iterable<InputT>>> output =
context.getOutput(transform);
+ context.setOutputDataStream(output, outDataStream);
+ context.setProducer(output, transform);
Review comment:
It would be nice if these explicit calls wouldn't be required. I believe
`context.setOutputDataStream` internally has the current transform available.
So we could perform it internally in the context.
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java
##########
@@ -1127,7 +1148,9 @@ public void translateNode(
keyedWorkItemStream.getExecutionEnvironment().addOperator(rawFlinkTransform);
- context.setOutputDataStream(context.getOutput(transform),
outDataStream);
+ final PCollection<KV<K, OutputT>> output =
context.getOutput(transform);
+ context.setOutputDataStream(output, outDataStream);
+ context.setProducer(output, transform);
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
