KevinGG commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r524516876
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -163,7 +165,8 @@ def __init__(self):
# the gRPC server serves.
self._test_stream_service_controllers = {}
self._cached_source_signature = {}
- self._tracked_user_pipelines = set()
Review comment:
LGTM, only one question:
Does the `UserPipelineTracker` clean up the user pipeline and their derived
pipelines when a user pipeline is out of scope (e.g., deleted or garbage
collected)? Or are the pipelines tracked never get garbage collected at all?
Is there any side effect when the user uses an outdated pipeline ref or a
new pipeline ref (from re-executions) that results in the same `__hash__` or
`__eq__`/`in` to be `True`? Will that give back a wrong user_pipeline when the
tracker thinks the pipeline is tracked while it's not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
