suztomo commented on a change in pull request #13342:
URL: https://github.com/apache/beam/pull/13342#discussion_r525465768
##########
File path: sdks/java/build-tools/beam-linkage-check.sh
##########
@@ -36,46 +36,60 @@ set -o pipefail
set -e
# These default artifacts are common causes of linkage errors.
-ARTIFACTS="beam-sdks-java-core
- beam-sdks-java-io-google-cloud-platform
- beam-runners-google-cloud-dataflow-java
- beam-sdks-java-io-hadoop-format"
-
-if [ ! -z "$1" ]; then
- ARTIFACTS=$1
+DEFAULT_ARTIFACT_LISTS=" \
Review comment:
> I just don't understand why we use both.
In general, running Linkage Check with multiple artifact may _hide_ linkage
errors that exist in dependencies of the one of the individual artifacts. (This
is the reason to use space-separated list.)
On the other hand, running Linkage Checker with multiple artifacts is
quicker than running Linkage Checker for individual artifacts one by one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
