nehsyc commented on a change in pull request #13405:
URL: https://github.com/apache/beam/pull/13405#discussion_r537882276
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -1112,6 +1128,17 @@ def run_ParDo(self, transform_node, options):
if is_stateful_dofn:
step.add_property(PropertyNames.USES_KEYED_STATE, 'true')
+ # Also checks whether the step allows shardable keyed states.
+ for pcoll in transform_node.outputs.values():
Review comment:
Got it. Yes I have a cl pending for adding translation to the service
which is waiting for this PR :) We are not considering adding this feature
patch for python runner v1 jobs though; it is disabled for non-unified worker:
https://github.com/apache/beam/blob/c1541796435cbd2ee775b6c89ec628f8564a3bcd/sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py#L365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]