nehsyc commented on a change in pull request #13405:
URL: https://github.com/apache/beam/pull/13405#discussion_r538027019
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -706,6 +714,16 @@ message PubSubWritePayload {
string id_attribute = 3;
}
+// Payload for GroupIntoBatches composite transform.
+message GroupIntoBatchesPayload {
+
+ // (Required) Max size of a batch.
+ int64 batch_size = 1;
+
+ // (Optional) Max duration a batch is allowed to be cached in states.
+ int64 max_buffering_duration_millis = 2;
Review comment:
Were you suggesting adding a comment here in the runner proto or in
GroupIntoBatches transform? I added some comments around here when changing the
API:
https://github.com/apache/beam/blob/c1541796435cbd2ee775b6c89ec628f8564a3bcd/sdks/python/apache_beam/transforms/util.py#L767
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/names.py
##########
@@ -69,6 +69,7 @@ class PropertyNames(object):
Property strings as they are expected in the CloudWorkflow protos.
"""
+ ALLOWS_SHARDABLE_STATE = 'allows_shardable_state'
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
