rosetn commented on a change in pull request #13591:
URL: https://github.com/apache/beam/pull/13591#discussion_r560639210
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -4544,6 +4546,19 @@ perUser.apply(ParDo.of(new DoFn<KV<String, ValueT>,
OutputT>() {
}));
{{< /highlight >}}
+{{< highlight python >}}
Review comment:
This Python section does not show up when I have Python selected.
http://apache-beam-website-pull-requests.storage.googleapis.com/13591/documentation/programming-guide/index.html#state-and-timers
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -4775,12 +4795,15 @@ _ = (p | 'Read per user' >> ReadPerUser()
#### 11.3.3. Dynamic timer tags {#dynamic-timer-tags}
-Beam also supports dynamically setting a timer tag using `TimerMap`. This
allows for setting multiple different timers
+Beam also supports dynamically setting a timer tag using `TimerMap` in Java
SDK. This allows for setting multiple different timers
Review comment:
"in the Java SDK."
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -4775,12 +4795,15 @@ _ = (p | 'Read per user' >> ReadPerUser()
#### 11.3.3. Dynamic timer tags {#dynamic-timer-tags}
-Beam also supports dynamically setting a timer tag using `TimerMap`. This
allows for setting multiple different timers
+Beam also supports dynamically setting a timer tag using `TimerMap` in Java
SDK. This allows for setting multiple different timers
in a `DoFn` and allowing for the timer tags to be dynamically chosen - e.g.
based on data in the input elements. A
timer with a specific tag can only be set to a single timestamp, so setting
the timer again has the effect of
overwriting the previous expiration time for the timer with that tag. Each
`TimerMap` is identified with a timer family
id, and timers in different timer families are independent.
+In Python SDK, a dynamic timer tag can be specified while calling timer.set()
or timer.clear(), by default the timer
Review comment:
I think these are two sentences? "... or `clear()`. By default, the
timer..."
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -4775,12 +4795,15 @@ _ = (p | 'Read per user' >> ReadPerUser()
#### 11.3.3. Dynamic timer tags {#dynamic-timer-tags}
-Beam also supports dynamically setting a timer tag using `TimerMap`. This
allows for setting multiple different timers
+Beam also supports dynamically setting a timer tag using `TimerMap` in Java
SDK. This allows for setting multiple different timers
in a `DoFn` and allowing for the timer tags to be dynamically chosen - e.g.
based on data in the input elements. A
timer with a specific tag can only be set to a single timestamp, so setting
the timer again has the effect of
overwriting the previous expiration time for the timer with that tag. Each
`TimerMap` is identified with a timer family
id, and timers in different timer families are independent.
+In Python SDK, a dynamic timer tag can be specified while calling timer.set()
or timer.clear(), by default the timer
Review comment:
`set()` and `clear()`
Unless you think it's too ambiguous without the class name. If that's the
case, then add these in code font.
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -4775,12 +4795,15 @@ _ = (p | 'Read per user' >> ReadPerUser()
#### 11.3.3. Dynamic timer tags {#dynamic-timer-tags}
-Beam also supports dynamically setting a timer tag using `TimerMap`. This
allows for setting multiple different timers
+Beam also supports dynamically setting a timer tag using `TimerMap` in Java
SDK. This allows for setting multiple different timers
in a `DoFn` and allowing for the timer tags to be dynamically chosen - e.g.
based on data in the input elements. A
timer with a specific tag can only be set to a single timestamp, so setting
the timer again has the effect of
overwriting the previous expiration time for the timer with that tag. Each
`TimerMap` is identified with a timer family
id, and timers in different timer families are independent.
+In Python SDK, a dynamic timer tag can be specified while calling timer.set()
or timer.clear(), by default the timer
Review comment:
"In the Python SDK"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
