xinyuiscool commented on a change in pull request #13667:
URL: https://github.com/apache/beam/pull/13667#discussion_r561224392
##########
File path: runners/samza/job-server/build.gradle
##########
@@ -32,7 +32,6 @@ applyJavaNature(
)
dependencies {
- compile project(":runners:samza")
Review comment:
RIght, this is the same as Flink and Spark job server. I was using
runShadow task to bring up the job server locally, and plan to add portability
tests later.
##########
File path: runners/samza/build.gradle
##########
@@ -53,21 +54,28 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.commons_io
- compile library.java.commons_lang3
- compile library.java.args4j
- compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "io.dropwizard.metrics:metrics-core:3.1.2"
compile "org.rocksdb:rocksdbjni:5.7.3"
- compile "org.apache.commons:commons-collections4:4.0"
compile "org.scala-lang:scala-library:2.11.8"
compile "org.apache.samza:samza-api:$samza_version"
compile "org.apache.samza:samza-core_2.11:$samza_version"
compile "org.apache.samza:samza-kafka_2.11:$samza_version"
compile "org.apache.samza:samza-kv_2.11:$samza_version"
+ compile project(":sdks:java:expansion-service")
+ permitUnusedDeclared "org.apache.samza:samza-kafka_2.11:1.5.0"
Review comment:
Makes sense. Most of them are used in runtime. I am not sure why the
samza-kv_2.11 module needs to be permitUnusedDeclared, as it contains Samza's
state backend api and we use it in the runner's state internals impl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
