apilloud commented on a change in pull request #14015:
URL: https://github.com/apache/beam/pull/14015#discussion_r578786490
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -160,8 +165,10 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x) {
SqlUserDefinedFunction udf = (SqlUserDefinedFunction) call.op;
if (udf.function instanceof ZetaSqlScalarFunctionImpl) {
ZetaSqlScalarFunctionImpl scalarFunction =
(ZetaSqlScalarFunctionImpl) udf.function;
- if (!scalarFunction.functionGroup.equals(
+ if (scalarFunction.functionGroup.equals(
SqlAnalyzer.USER_DEFINED_JAVA_SCALAR_FUNCTIONS)) {
+ udfs.add(i);
+ } else {
Review comment:
Only RexCall has getOperands. I was under the impression that these
operands are garenteed to be prior entries returned in ExprList. It will be a
little while before I have time to verify. If that is not the case, it is easy
to transform the ExprList into that form. That will need to be true for this to
be correct and for calc splitting to be easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
