kennknowles commented on a change in pull request #14015:
URL: https://github.com/apache/beam/pull/14015#discussion_r578820607
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -160,8 +165,10 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x) {
SqlUserDefinedFunction udf = (SqlUserDefinedFunction) call.op;
if (udf.function instanceof ZetaSqlScalarFunctionImpl) {
ZetaSqlScalarFunctionImpl scalarFunction =
(ZetaSqlScalarFunctionImpl) udf.function;
- if (!scalarFunction.functionGroup.equals(
+ if (scalarFunction.functionGroup.equals(
SqlAnalyzer.USER_DEFINED_JAVA_SCALAR_FUNCTIONS)) {
+ udfs.add(i);
+ } else {
Review comment:
Yea that is how I expected calc splitting to be implemented as well. I
thought that the program was constrained to have that form as well.
Didn't you demonstrate an example like `increment(1 + 1)` where the `+` was
executed by `BeamCalcRel`? This is what prompted me to read the code to see if
the operands were checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
