chamikaramj commented on a change in pull request #11767:
URL: https://github.com/apache/beam/pull/11767#discussion_r593930566
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
##########
@@ -135,16 +135,36 @@
import org.junit.rules.TestRule;
import org.junit.runner.Description;
import org.junit.runner.RunWith;
-import org.junit.runners.JUnit4;
+import org.junit.runners.Parameterized;
Review comment:
I didn't look into tests in detail yet but given the extremely large
change and number of potential users, we should try to get close to 100% code
coverage through unit testing and 100% test parity with existing streaming
inserts tests (both unit and integration).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
