TheNeuralBit commented on a change in pull request #14176:
URL: https://github.com/apache/beam/pull/14176#discussion_r592829797
##########
File path: sdks/python/setup.py
##########
@@ -131,6 +131,10 @@ def get_version():
# Avro 1.9.2 for python3 was broken. The issue was fixed in version 1.9.2.1
'avro-python3>=1.8.1,!=1.9.2,<1.10.0',
'crcmod>=1.7,<2.0',
+ # dataclasses backport for Python 3.6. No version boundary so that Python
+ # picks the correct one based on its version. For more details, see
+ # https://pypi.org/project/dataclasses/
+ 'dataclasses',
Review comment:
What I meant was to put a `python_version<3.7` on the requirement, that
way it will just be ignored entirely for newer versions (and it will also
remind us to drop the dep in the future).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
