TheNeuralBit commented on a change in pull request #14176:
URL: https://github.com/apache/beam/pull/14176#discussion_r592831050
##########
File path: sdks/python/setup.py
##########
@@ -131,6 +131,10 @@ def get_version():
# Avro 1.9.2 for python3 was broken. The issue was fixed in version 1.9.2.1
'avro-python3>=1.8.1,!=1.9.2,<1.10.0',
'crcmod>=1.7,<2.0',
+ # dataclasses backport for Python 3.6. No version boundary so that Python
+ # picks the correct one based on its version. For more details, see
+ # https://pypi.org/project/dataclasses/
+ 'dataclasses',
Review comment:
It looks like we don't actually have any examples of this in our
setup.py to draw from anymore! We used to do it all over the place because of
py2.7 and 3.5. Here is an example of what I'm talking about:
https://stackoverflow.com/a/32643122/2952954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
