lostluck commented on pull request #14504:
URL: https://github.com/apache/beam/pull/14504#issuecomment-817192256
A nit on the PostCommit.
Go's PostCommit is the "Dataflow PostCommit" largely for historical
reasons.
It should be shifted to the Dataflow column as a result, with the ULR
column left blank.
Go doesn't have a ULR PostCommit, it has one as a PreCommit, since the
surface is currently small & fast enough to run it as a precommit. That's
the "PreCommit_GoPortable" entry.
Go Precommits are currently correct in your sheet.
I assume the example targets are new? I love this idea! The Go examples are
not exercised regularly. I've made a note in the Big Go SDK Audit
spreadsheet I'm working on to add Go targets for the Examples (likely
leaning on the ULR more than anything).
On Fri, 9 Apr 2021 at 16:43, Kenn Knowles ***@***.***> wrote:
> My hope is for the "SDK/Transform PostCommit" tests that we can get
> separate icons for the various IO connectors or at least modules of
> connectors. All dependent on how easily we can automatically produce the
> Jenkins jobs we want, and also automatically summarize multiple Jenkins
> jobs so they don't get unwieldy.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/14504#issuecomment-817029167>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ADKDOFKRHPRO37GPSS27BRLTH6GI5ANCNFSM42V2SEXQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
