lostluck commented on pull request #14504: URL: https://github.com/apache/beam/pull/14504#issuecomment-819100139
Kenn, adding the Go PostCommit Badge to the Dataflow column where it belongs would be adding clarity to that badge being run against dataflow. Arguably at this point, we should rename it to Dataflow anyway to match the Spark and Flink validations, and do away with the "generic" PostCommit for Go. Go being Portable Only means the speedy ULR variant we're using as a Portable Precommit means we're getting most signal from that anyway, and don't need a "generic" precommit target. (renaming would not need to happen in this PR, but I do insist the badge be put in the right place now, since that's what's being discussed). Per my ongoing auditting, the Go SDK needs to bolster what is covered for testing and examples, especially for various transforms, so if you insist on a badge being only in one place, the Dataflow column is more correct than the "post commit" column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
