tvalentyn commented on a change in pull request #14783:
URL: https://github.com/apache/beam/pull/14783#discussion_r630593570
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -299,6 +299,9 @@ def _replace_if_needed(self, original_transform_node):
original_transform_node.full_label,
original_transform_node.inputs)
+ replacement_transform_node.resource_hints = (
+ original_transform_node.resource_hints)
Review comment:
Thanks for catching this. Would a factory method in AppliedPTransform be
a better way to generate replacement in a way that replacement doesn't lose
some important fields that will be defined later?
Also, should this preserve `envirnonment` and `annotations` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
